Add github job for checking code formatting #42
+198
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sogartar
force-pushed
the
code-formatting
branch
from
d97eadc to
d0999c0
Compare
|
Could you separate adding the formatting work / job from the actual reformatting of the code. It should help avoid conflating functional changes from purely formatting changes. |
sogartar
force-pushed
the
code-formatting
branch
from
d0999c0 to
b9b3e3c
Compare
sogartar
changed the title
|
@rsuderman, I moved the code formatting to a new PR #52. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not sure if you want to format the code at one go. I can just add the github job.
For the github job I copied the script from https://github.com/iree-org/iree/blob/0c7fcbc2eba18aa0ece089f3d533a2b5164cdde8/third_party/format_diff/format_diff.py. Maybe not the best approach as it introduces code duplication.